Conversation
- Add --collection parameter examples to README.md - Update docs/features.md with collection filtering capability - Show usage examples for both bonds and commodities collections
…pgAdmin/performance doc; modernize features examples; link docs and add troubleshooting + disclaimer
- Removed `simple_csv_exporter.py` and replaced it with `trades_parser.py` for improved trade data parsing capabilities. - Introduced `tv_alert_exporter.py` to replace the deprecated `tradingview_alert_exporter.py`, maintaining backward compatibility with a shim. - Added a new Tailwind CSS configuration file for styling reports. - Updated tests to reflect changes in module imports and ensure compatibility with the new structure. - Created a diagnostic tool `diagnose_cache.py` to inspect cache manager statistics and recent entries. - Implemented a new test suite for best strategy upsert functionality in the database.
…hness warning for daily data; add --no-cache/--fresh flags; source coverage probe and dynamic ordering; pass use_cache through direct backtests; update data manager and CLI accordingly
… TV alerts, --exports ai, AI reco HTML (dark Tailwind) + CSV; update README/cli-guide/docker/features; prefer 1d for filenames; fix CLI try/except blocks; tweak tv_alert_exporter typing ignores
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
…tents fix: update PortfolioManager import path to maintain public API stability feat: add test-mode override for lightweight SQLite in unified_models
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
LouisLetcher
pushed a commit
that referenced
this pull request
Sep 3, 2025
# Pull Request
## Description
Unify export naming/paths across CSV, HTML, TV alerts, and AI recos;
make TV alerts DB-backed; add an AI export mode; and upgrade AI reco
HTML for analyst workflows. Update docs to reflect current behavior and
add a forward-looking roadmap.
## Type of Change
- [ ] Bug fix
- [ X] New feature
- [ ] Breaking change
- [ X] Documentation update
- [ ] Performance improvement
- [ X] Code refactoring
## Changes Made
- Unified filenames: {Collection}_Collection_{Year}_{Quarter}_{Interval}
across CSV, HTML, TV, AI.
- CSV: default path exports/csv, interval-aware filtering (matches
filename), sanitize collection names.
- HTML reports: organizer and reporter now save to unified naming under
exports/reports/<Year>/<Quarter>/.
- TV alerts: switched to DB-backed export (no HTML parsing), unified
naming, path exports/tv_alerts/<Year>/<Quarter>/; CLI passes symbols +
interval.
- AI recos: unified naming to exports/ai_reco/<Year>/<Quarter>/
(Markdown + HTML dark Tailwind + CSV for analysts, with CSV download
link in HTML).
- CLI: added --exports ai; selective exporters for csv, report,
tradingview, ai, or all; filenames prefer 1d interval when multiple
intervals are present.
- Docs: updated README, CLI guide, Docker guide, and Features doc;
documented locations/naming and added a roadmap (walk-forward
validation, portfolio construction, execution modeling, monitoring,
advanced risk, GPU).
Minor refactors: improved try/except structure in CLI; ReportOrganizer
fallback for legacy HTML names; typing ignore codes for TV exporter.
## Testing
- [X ] Tests pass locally
- [ X] New tests added (if applicable)
- [ X] Manual testing completed
## Checklist
- [ X] Code follows project style guidelines
- [ X] Self-review completed
- [ X] Documentation updated (if needed)
- [ X] No breaking changes (or documented)
## Related Issues
Fixes #(issue number)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Unify export naming/paths across CSV, HTML, TV alerts, and AI recos; make TV alerts DB-backed; add an AI export mode; and upgrade AI reco HTML for analyst workflows. Update docs to reflect current behavior and add a forward-looking roadmap.
Type of Change
Changes Made
Minor refactors: improved try/except structure in CLI; ReportOrganizer fallback for legacy HTML names; typing ignore codes for TV exporter.
Testing
Checklist
Related Issues
Fixes #(issue number)