Skip to content

Comments

Feature/clean collections#49

Merged
LouisLetcher merged 14 commits intomainfrom
feature/clean_collections
Sep 1, 2025
Merged

Feature/clean collections#49
LouisLetcher merged 14 commits intomainfrom
feature/clean_collections

Conversation

@LouisLetcher
Copy link
Collaborator

Pull Request

Description

Unify export naming/paths across CSV, HTML, TV alerts, and AI recos; make TV alerts DB-backed; add an AI export mode; and upgrade AI reco HTML for analyst workflows. Update docs to reflect current behavior and add a forward-looking roadmap.

Type of Change

  • Bug fix
  • [ X] New feature
  • Breaking change
  • [ X] Documentation update
  • Performance improvement
  • [ X] Code refactoring

Changes Made

  • Unified filenames: {Collection}Collection{Year}{Quarter}{Interval} across CSV, HTML, TV, AI.
  • CSV: default path exports/csv, interval-aware filtering (matches filename), sanitize collection names.
  • HTML reports: organizer and reporter now save to unified naming under exports/reports///.
  • TV alerts: switched to DB-backed export (no HTML parsing), unified naming, path exports/tv_alerts///; CLI passes symbols + interval.
  • AI recos: unified naming to exports/ai_reco/// (Markdown + HTML dark Tailwind + CSV for analysts, with CSV download link in HTML).
  • CLI: added --exports ai; selective exporters for csv, report, tradingview, ai, or all; filenames prefer 1d interval when multiple intervals are present.
  • Docs: updated README, CLI guide, Docker guide, and Features doc; documented locations/naming and added a roadmap (walk-forward validation, portfolio construction, execution modeling, monitoring, advanced risk, GPU).
    Minor refactors: improved try/except structure in CLI; ReportOrganizer fallback for legacy HTML names; typing ignore codes for TV exporter.

Testing

  • [X ] Tests pass locally
  • [ X] New tests added (if applicable)
  • [ X] Manual testing completed

Checklist

  • [ X] Code follows project style guidelines
  • [ X] Self-review completed
  • [ X] Documentation updated (if needed)
  • [ X] No breaking changes (or documented)

Related Issues

Fixes #(issue number)

- Add --collection parameter examples to README.md
- Update docs/features.md with collection filtering capability
- Show usage examples for both bonds and commodities collections
…pgAdmin/performance doc; modernize features examples; link docs and add troubleshooting + disclaimer
- Removed `simple_csv_exporter.py` and replaced it with `trades_parser.py` for improved trade data parsing capabilities.
- Introduced `tv_alert_exporter.py` to replace the deprecated `tradingview_alert_exporter.py`, maintaining backward compatibility with a shim.
- Added a new Tailwind CSS configuration file for styling reports.
- Updated tests to reflect changes in module imports and ensure compatibility with the new structure.
- Created a diagnostic tool `diagnose_cache.py` to inspect cache manager statistics and recent entries.
- Implemented a new test suite for best strategy upsert functionality in the database.
…hness warning for daily data; add --no-cache/--fresh flags; source coverage probe and dynamic ordering; pass use_cache through direct backtests; update data manager and CLI accordingly
… TV alerts, --exports ai, AI reco HTML (dark Tailwind) + CSV; update README/cli-guide/docker/features; prefer 1d for filenames; fix CLI try/except blocks; tweak tv_alert_exporter typing ignores
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@codecov-commenter
Copy link

@LouisLetcher LouisLetcher merged commit 54d1e7b into main Sep 1, 2025
5 checks passed
@LouisLetcher LouisLetcher deleted the feature/clean_collections branch September 1, 2025 11:08
LouisLetcher pushed a commit that referenced this pull request Sep 3, 2025
# Pull Request

## Description
Unify export naming/paths across CSV, HTML, TV alerts, and AI recos;
make TV alerts DB-backed; add an AI export mode; and upgrade AI reco
HTML for analyst workflows. Update docs to reflect current behavior and
add a forward-looking roadmap.

## Type of Change
- [ ] Bug fix
- [ X] New feature
- [ ] Breaking change
- [ X] Documentation update
- [ ] Performance improvement
- [ X] Code refactoring

## Changes Made
- Unified filenames: {Collection}_Collection_{Year}_{Quarter}_{Interval}
across CSV, HTML, TV, AI.
- CSV: default path exports/csv, interval-aware filtering (matches
filename), sanitize collection names.
- HTML reports: organizer and reporter now save to unified naming under
exports/reports/<Year>/<Quarter>/.
- TV alerts: switched to DB-backed export (no HTML parsing), unified
naming, path exports/tv_alerts/<Year>/<Quarter>/; CLI passes symbols +
interval.
- AI recos: unified naming to exports/ai_reco/<Year>/<Quarter>/
(Markdown + HTML dark Tailwind + CSV for analysts, with CSV download
link in HTML).
- CLI: added --exports ai; selective exporters for csv, report,
tradingview, ai, or all; filenames prefer 1d interval when multiple
intervals are present.
- Docs: updated README, CLI guide, Docker guide, and Features doc;
documented locations/naming and added a roadmap (walk-forward
validation, portfolio construction, execution modeling, monitoring,
advanced risk, GPU).
Minor refactors: improved try/except structure in CLI; ReportOrganizer
fallback for legacy HTML names; typing ignore codes for TV exporter.

## Testing
- [X ] Tests pass locally
- [ X] New tests added (if applicable)
- [ X] Manual testing completed

## Checklist
- [ X] Code follows project style guidelines
- [ X] Self-review completed
- [ X] Documentation updated (if needed)
- [ X] No breaking changes (or documented)

## Related Issues
Fixes #(issue number)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants